replication: add IsEmpty method to GTIDSet interface & implementations #1019
+30
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is my first contribution to this repo; it seemed like a pretty small and straightforward change so I thought it was simplest to directly submit it as a PR. I'm happy to take any feedback on it :-) |
wesleywright
force-pushed
the
gtid-set-is-empty
branch
from
088d493 to
bf94d73
Compare
lance6716
approved these changes
Mar 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality of life improvement. For some use cases (such as writing tests), it is common to want to check if a given GTID set is empty or not. Currently this requires using
Equal()with an empty GTID set (which takes a decent amount of boilerplate) or else requires inspecting theSetfield (which is specific to a single concrete implementation of theGTIDSetinterface).This commits adds a simple
IsEmpty() boolmethod to theGTIDSetinterface for this use case, as well as implementations for bothMysqlGTIDSetandMariadbGTIDSet.